Elxis CMS Forum

Support => General => Topic started by: kyomar on April 11, 2021, 09:24:55

Title: Elxis 5.2 - template copy & usr.config.css
Post by: kyomar on April 11, 2021, 09:24:55
Hi, I have started testing the upgrade from 5.1 to 5.2 and so far all looks okay (frontend). I really like the upgraded gallery plugin and the custom styling as well as the template copy function. My questions:
1) user.config.css files are still listed after check file-system. Do they get updated/overridden again with a new update (hope not)?
2) the parameters of the newly copied template are not being filled with the ones from the origin template. I can enter stuff (e.g. copyright text) but has no effect (frontend the old copyright text is shown).
Perhaps I am missing something.
Thanks a lot!
Title: Re: Elxis 5.2 - template copy & usr.config.css
Post by: datahell on April 11, 2021, 19:00:02
1. No they don't get overwritten. I published new hashes excluding them from standard filesystem and now they wont be displayed as "modified".

2. An extension, and especially a template is a complex application. The copy template feature does want it says, copies a template and creates a new extension with a different name. However a simple rename is not enough as a template has paths pointing to the original template, internal code , classes and functions of the original template, etc. Elxis tries to fix some of these issues as good as possible (mostly the paths, the XML and the language files). The final result depends on the chosen original template's complexity and structure. You should consider the new generated template as a first step of further modifications. Open the generated template and perform fixes if needed. This feature built for those want to develop a new template starting from something already existing. From this point of view it is a huge help as it does all the initial hard job for you. Something that is important, we also note it in copy window instructions, is to provide a totally different name. For instance if the original template is Five, don't rename it to Five2 but to something totally different, like Titanic
Title: Re: Elxis 5.2 - template copy & usr.config.css
Post by: kyomar on April 12, 2021, 04:31:03
Hi datahell,
Thanks a lot for the clarifications.
1) The user.config.css files don't show up anymore in the check file-system list - great!
2) I figured it out how to get the parameters sorted in the newly copied template. I had to edit following files:
a) index.php
line32)   $tpl5 = new templateFive(); to $tpl5 = new templateNewName();
b) five.class.php
line15)   class templateFive { to class templateNewName {
line43)   $xmlpath = ELXIS_PATH.'/templates/five/five.xml'; to $xmlpath = ELXIS_PATH.'/templates/newname/newname.xml';
line181) '.$db->quote('five').' to '.$db->quote('newname').'

After that I could enter the Parameters like in the "old" template and all works. I hope I did the right edits.

Thanks again for the help - greatly appreciated.
Title: Re: Elxis 5.2 - template copy & usr.config.css
Post by: datahell on April 12, 2021, 19:00:22
The class name is not needed to be changed, however its ok if you do so.
Line 43: This should have been changed, strange.
Line 181: Yes, here is the problem. The old template name remained and this is why you got the parameters of template Five instead of the new one. I will fix it.
Title: Re: Elxis 5.2 - template copy & usr.config.css
Post by: kyomar on April 13, 2021, 01:14:08
datahell, thanks for looking into this and fixing it. i am glad I could help and give something back.
Line43: this could have been correct, wasn't sure anymore and therefore included it (better safe than sorry).
With these new functions Elxis became even better - I am loving it.