Elxis CMS Forum

Extensions => Modules => Topic started by: illusion-web-solutions on February 12, 2013, 14:00:36

Title: mod superfish menu
Post by: illusion-web-solutions on February 12, 2013, 14:00:36
we are working in a project and after we finished it under final testing we faced a problem

we used ( mod EI superfish menu ) and customized it and every thing is great
but after we activated SEO Pro we found that all the menu li get the class current and this destroyed the lock of the website
any suggestions to fix this issue please

thanks in advance
Title: Re: mod superfish menu
Post by: Ivan Trebješanin on February 12, 2013, 14:38:14
Can you give us a link, I think menu classes have nothing to do with SEOpro.
Title: Re: mod superfish menu
Post by: illusion-web-solutions on February 12, 2013, 14:43:49
unfortintly it is not a live project yet

but as we see now

it is not about CSS

we checked the EI Super fish menu module php file

 
Code: [Select]

/****************************************************/
/* PROCESS RECURSE LIST MENU */
/****************************************************/

private function mosRecurseListMenu( $id, $level, &$children, $open, &$indents, $class_sfx, $highlight ) {
global $Itemid, $mainframe;
if (@$children[$id]) {
$n = min( $level, count( $indents )-1 );
if ($level==0) {
echo '<ul class="'.$this->excss.'">';
} else {
echo $indents[$n][0];
}
foreach ($children[$id] as $row) {

switch ($row->type) {
case 'separator':
// do nothing
$row->link = "seperator";
break;

case 'url':
if ( eregi( 'index.php\?', $row->link ) ) {
if ( !eregi( 'Itemid=', $row->link ) ) {
$row->link .= '&Itemid='.$row->id;
}
}
break;
default:
$row->link .= '&Itemid='.$row->id;
break;
}
$li =  "\n".$indents[$n][1] ;
$current_itemid = trim( mosGetParam( $_REQUEST, 'Itemid', 0 ) );
if ($row->link != 'seperator' && $current_itemid == $row->id || $row->id == $highlight || (sefRelToAbs($Itemid == $id))) {
$li = '<li class="current">';
}
echo $li;
echo $this->mosGetLink( $row, $level, $class_sfx );
$this->mosRecurseListMenu( $row->id, $level+1, $children, $open, $indents, $class_sfx, "" );
echo $indents[$n][2];
}

echo "\n".$indents[$n][3];
}

}


and we tested a pure module setup on a clear non changed Elxis 2009 site and it also gives the sam to all li in the sf-menu a class of "Current"
and as the
.current class is not configured in the css of super fish menu it looks nice but in the code it gives all li a class of Current
Title: Re: mod superfish menu
Post by: illusion-web-solutions on February 12, 2013, 14:45:18
note that without SEO pro it work fine with no problems with SEO Basic also there is no problems
Title: Re: mod superfish menu
Post by: Ivan Trebješanin on February 12, 2013, 15:18:44
You are right, I just checked at one site where I used that module and it is giving "current" class to all menu items. However, I never had any problems with it. I obviously had "current" class from the beginning, so I never noticed. I can't give the link here, but it's working fine. Just edit css.
Title: Re: mod superfish menu
Post by: illusion-web-solutions on February 12, 2013, 15:37:11
in CSS the class current is set to give defrent font color so the current page will be uniqe

and as all the li get the same class "Current" so they all are going to be the same when SEO Pro is active

lets say we use this as the current css

Code: [Select]
.current:nth-child(1n+0) a {
color: #007eff;
background: url(../images/menu_hover.png) repeat;
text-shadow: 3px 3px 3px 3px #000;
}


we test also using
Code: [Select]
ul.sf-menu li.current a {
color: #007eff;
background: url(../images/menu_hover.png) repeat;
text-shadow: 3px 3px 3px 3px #000;
}

both when activating SEO Pro give all the menu links same styling as all of them are all classed to "Current"
Title: Re: mod superfish menu
Post by: illusion-web-solutions on February 12, 2013, 15:38:23
You are right, I just checked at one site where I used that module and it is giving "current" class to all menu items. However, I never had any problems with it. I obviously had "current" class from the beginning, so I never noticed. I can't give the link here, but it's working fine. Just edit css.


try to enable SEO Pro is it still working fine ?? all your menu links will be the same style for current class


any suggestions ?
Title: Re: mod superfish menu
Post by: illusion-web-solutions on March 06, 2013, 11:36:54
any one got any suggestion to fix this issue ?
Title: Re: mod superfish menu
Post by: datahell on March 07, 2013, 13:13:11
It is a specific extension by a third party developer. Contact him, no one else can help you.